首页
学习
活动
专区
圈层
工具
发布
社区首页 >问答首页 >战舰游戏(2人) Python

战舰游戏(2人) Python
EN

Code Review用户
提问于 2017-06-01 16:37:50
回答 1查看 3.7K关注 0票数 3

我一直在工作的2人战舰游戏,并最终使它发挥作用,没有bug。

我在这里发这篇文章是想问问你对此的看法。是否有任何修改可以提高代码的性能/总体布局?

如果您遇到任何与代码本身有关的问题(可能还没有发现bug ),那么如果您能告诉我,我将非常感激。

这款游戏是一款相当简单的基于控制台的战舰游戏,玩家轮流使用它来击沉由5x5棋盘上的x和y坐标定义的共同船。

代码语言:javascript
复制
from random import randint

game_board = []

player_one = {
    "name": "Player 1",
    "wins": 0,
}

player_two = {
    "name": "Player 2",
    "wins": 0,
}

colors = {
    "reset":"\033[00m",
    "red":"\033[91m",
    "blue":"\033[94m",
    "cyan":"\033[96m",
}

# Building our 5 x 5 board
def build_game_board(board):
    for item in range(5):
        board.append(["O"] * 5)

def show_board(board):
    for row in board:
        print(" ".join(row))

# Defining ships locations
def load_game(board):
    print("WELCOME TO BATTLESHIP!")
    print("Find and sink the ship!")
    del board[:]
    build_game_board(board)
    print(colors['blue'])
    show_board(board)
    print(colors['reset'])
    ship_col = randint(1, len(board))
    ship_row = randint(1, len(board[0]))
    return {
        'ship_col': ship_col,
        'ship_row': ship_row,
    }

ship_points = load_game(game_board)

# Players will alternate turns.
def player_turns(total_turns):

    if total_turns % 2 == 0:
        total_turns += 1
        return player_one

    return player_two

# Allows new game to start
def play_again():

    positive = ["yes", "y"] 
    negative = ["no", "n"]

    global ship_points

    while True:
        answer = input("Play again? [Y(es) / N(o)]: ").lower().strip()
        if answer in positive:
            ship_points = load_game(game_board)
            main()
            break

        elif answer in negative:   
            print("Thanks for playing!")
            exit()

# What will be done with players guesses
def input_check(ship_row, ship_col, player, board):
    guess_col = 0
    guess_row = 0
    while True:

        try:
            guess_row = int(input("Guess Row:")) - 1
            guess_col = int(input("Guess Col:")) - 1
        except ValueError:

            print("Enter a number only: ")
            continue
        else:

            break
    match = guess_row == ship_row - 1 and guess_col == ship_col - 1
    not_on_game_board = (guess_row < 0 or guess_row > 4) or (guess_col < 0 or guess_col > 4)

    if match:
        player["wins"] += 1
        print("Congratulations! You sunk my battleship!")
        print('The current match score is %d : %d (Player1 : Player2)' % (player_one["wins"], player_two["wins"]))
        print("Thanks for playing!")
        play_again()

    elif not match:
        if not_on_game_board:
            print("Oops, that's not even in the ocean.")

        elif board[guess_row][guess_col] == "X" or board[guess_row][guess_col] == "Y":
            print("You guessed that one already.")

        else:
            print("You missed my battleship!")
            if player == player_one:
                board[guess_row][guess_col] = "X"
            else:
                board[guess_row][guess_col] = "Y"

        print(colors['cyan'])
        show_board(game_board)
        print(colors['reset'])

    else:
        return 0


begin = input("Type 'start' to begin: ")

while (begin != str('start')):
    begin = input("Type 'start' to begin: ")

def main():

    for turns in range(6):

        if player_turns(turns) == player_one:
            print(ship_points)
            print("Player One")
            input_check(
                ship_points['ship_row'],
                ship_points['ship_col'],
                player_one, game_board
            )

        elif player_turns(turns) == player_two:
            print("Player Two")
            input_check(
                ship_points['ship_row'],
                ship_points['ship_col'],
                player_two, game_board
            )

        if turns == 5:
            print("This game is a draw.")
            print(colors['red'])
            show_board(game_board)
            print(colors['reset'])
            print('The current match score is %d : %d (Player1 : Player2)' % (player_one["wins"], player_two["wins"]))
            play_again()

if __name__ == "__main__":
    main()
EN

回答 1

Code Review用户

回答已采纳

发布于 2017-07-07 21:14:00

整体清洁,易于阅读。下面是我的nits和优化:

  1. 在您的load_game()函数中,如果要重新创建板,则不需要执行del board[:]。只需调用build_game_board()并将其重写如下: def build_game_board():board = [“0”表示I在范围内(5) for j in range(5)]
  2. 您可以这样重写show_board() (小nit,利用列表理解):def show_board(板):print(“”.join(行)表示板中的一行).join("\n"))
  3. 如果您总是要在5x5板上播放,请考虑将其作为变量存储。尺寸=5.ship_col = randint(1,大小)
  4. 这有什么意义?如果匹配:..。elif不匹配:.否则:返回0为什么不呢?如果匹配:..。其他:..。
  5. 您可以将其重新定位到if __name__ == 'main':块中: begin =input(“键入'start‘to begin:"),而(begin != str( 'start’)):begin =input(”键入‘start’to begin:")
  6. 尽量避免全局变量。在您的示例中,您可以在主程序中声明所有它们,并将它们传递给各自的函数。(如果这样做,我上面的build_game_board()函数就不能工作,但是您可以轻松地重写它)。
票数 3
EN
页面原文内容由Code Review提供。腾讯云小微IT领域专用引擎提供翻译支持
原文链接:

https://codereview.stackexchange.com/questions/164697

复制
相关文章

相似问题

领券
问题归档专栏文章快讯文章归档关键词归档开发者手册归档开发者手册 Section 归档