首页
学习
活动
专区
圈层
工具
发布
社区首页 >问答首页 >是否有一种方法可以使类似(几乎重复的)代码自动化,并使其像函数一样?

是否有一种方法可以使类似(几乎重复的)代码自动化,并使其像函数一样?
EN

Stack Overflow用户
提问于 2021-04-26 09:21:10
回答 2查看 60关注 0票数 2

下面是代码:这可能没有多大意义,但我的问题与语法无关。

本质上..。有多达7张图片,并安排在预定义的布局和其他东西.如何使这个重复的、不可扩展的代码更加简化?

代码语言:javascript
复制
im1 = None
im2 = None
im3 = None
im4 = None
im5 = None
im6 = None
im7 = None

if com == 2:
#    cv2.imshow("")
    layout = int(input("Enter layout number: "))
    im1 = im_1()
    im2 = im_2()
    while (im1 == im2):
        print("Invalid")
        im1 = im_1()
        im2 = im_2()
elif com == 3:
#    cv2.imshow("")
    layout = int(input("Enter layout number: "))
    im1 = im_1()
    im2 = im_2()
    im3 = im_3()
    while (im1 == im2) | (im1 == im3) | (im2 == im3):
        print("Invalid")
        im1 = im_1()
        im2 = im_2()
        im3 = im_3()
elif com == 4:
#    cv2.imshow("")
    layout = int(input("Enter layout number: "))
    im1 = im_1()
    im2 = im_2()
    im3 = im_3()
    im4 = im_4()
    while (im1 == im2) | (im1 == im3) | (im1 == im4) | (im2 == im3) | (im2 == im4) | (im3 == im4):
        print("Invalid")
        im1 = im_1()
        im2 = im_2()
        im3 = im_3()
        im4 = im_4()
elif com == 5:
#    cv2.imshow("Layouts: 5", l5)
    layout = int(input("Enter layout number: "))
    im1 = im_1()
    im2 = im_2()
    im3 = im_3()
    im4 = im_4()
    im5 = im_5()
    while (im1 == im2) | (im1 == im3) | (im1 == im4) | (im1 == im5) | (im2 == im3) | (im2 == im4) | (im2 == im5) | (im3 == im4) | (im3 == im5) | (im4 == im5):
        print("Invalid")
        im1 = im_1()
        im2 = im_2()
        im3 = im_3()
        im4 = im_4()
        im5 = im_5()
elif com == 6:
#    cv2.imshow("")
    layout = int(input("Enter layout number: "))
    im1 = im_1()
    im2 = im_2()
    im3 = im_3()
    im4 = im_4()
    im5 = im_5()
    im6 = im_6()
    while (im1 == im2) | (im1 == im3) | (im1 == im4) | (im1 == im5) | (im1 == im6) | (im2 == im3) | (im2 == im4) | (im2 == im5) | (im2 == im6) | (im3 == im4) | (im3 == im5) | (im3 == im6) | (im4 == im5) | (im4 == im6) | (im5 == im6):
        print("Invalid")
        im1 = im_1()
        im2 = im_2()
        im3 = im_3()
        im4 = im_4()
        im5 = im_5()
        im6 = im_6()
elif com == 7:
#    cv2.imshow("")
    layout = int(input("Enter layout number: "))
    im1 = im_1()
    im2 = im_2()
    im3 = im_3()
    im4 = im_4()
    im5 = im_5()
    im6 = im_6()
    im7 = im_7()
    while (im1 == im2) | (im1 == im3) | (im1 == im4) | (im1 == im5) | (im1 == im6) | (im1 == im7) | (im2 == im3) | (im2 == im4) | (im2 == im5) | (im2 == im6) | (im2 == im7) | (im3 == im4) | (im3 == im5) | (im3 == im6) | (im3 == im7) | (im4 == im5) | (im4 == im6) | (im4 == im7) | (im5 == im6) | (im5 == im7) | (im6 == im7):
        print("Invalid")
        im1 = im_1()
        im2 = im_2()
        im3 = im_3()
        im4 = im_4()
        im5 = im_5()
        im6 = im_6()
        im7 = im_7()

这是一种比较图像的计算机视觉代码,但它只能工作到7,因为我必须先预先定义图像。com实际上是用户输入的,如果它是<7.内存仍然用于定义7幅图像,并且不允许com >7。

而且,如果您看到,它只工作到7,因为图像比较还没有被硬编码到>7。但是com =n的逻辑非常容易硬编码,但是非常辛苦。是否有一种方法可以为n个图像/术语编写这段代码,其中它定义了变量的确切数量,并自定义为com =n的比较/布局部分?

同样,我们能否将其扩展到以下方面:

代码语言:javascript
复制
if i != 0:
                if i == 1:
                    anim1 = cv2.imread("anim_1.jpg")
                    border_b = cv2.copyMakeBorder(anim1, bt, bt, bt, bt, cv2.BORDER_CONSTANT, value = c_b)
                    border_w = cv2.copyMakeBorder(border_b, wt, wt, wt, wt, cv2.BORDER_CONSTANT, value = c_w)
                    anim1 = border_w
                if i == 2:
                    anim2 = cv2.imread("anim_2.jpg")
                    border_b = cv2.copyMakeBorder(anim2, bt, bt, bt, bt, cv2.BORDER_CONSTANT, value = c_b)
                    border_w = cv2.copyMakeBorder(border_b, wt, wt, wt, wt, cv2.BORDER_CONSTANT, value = c_w)
                    anim2 = border_w
                if i == 3:
                    anim3 = cv2.imread("anim_3.jpg")
                    border_b = cv2.copyMakeBorder(anim3, bt, bt, bt, bt, cv2.BORDER_CONSTANT, value = c_b)
                    border_w = cv2.copyMakeBorder(border_b, wt, wt, wt, wt, cv2.BORDER_CONSTANT, value = c_w)
                    anim3 = border_w
                if i == 4:
                    anim4 = cv2.imread("anim_4.jpg")
                    border_b = cv2.copyMakeBorder(anim4, bt, bt, bt, bt, cv2.BORDER_CONSTANT, value = c_b)
                    border_w = cv2.copyMakeBorder(border_b, wt, wt, wt, wt, cv2.BORDER_CONSTANT, value = c_w)
                    anim4 = border_w
                if i == 5:
                    anim5 = cv2.imread("anim_5.jpg")
                    border_b = cv2.copyMakeBorder(anim5, bt, bt, bt, bt, cv2.BORDER_CONSTANT, value = c_b)
                    border_w = cv2.copyMakeBorder(border_b, wt, wt, wt, wt, cv2.BORDER_CONSTANT, value = c_w)
                    anim5 = border_w
                if i == 6:
                    anim6 = cv2.imread("anim_6.jpg")
                    border_b = cv2.copyMakeBorder(anim6, bt, bt, bt, bt, cv2.BORDER_CONSTANT, value = c_b)
                    border_w = cv2.copyMakeBorder(border_b, wt, wt, wt, wt, cv2.BORDER_CONSTANT, value = c_w)
                    anim6 = border_w
                if i == 7:
                    anim7 = cv2.imread("anim_7.jpg")
                    border_b = cv2.copyMakeBorder(anim7, bt, bt, bt, bt, cv2.BORDER_CONSTANT, value = c_b)
                    border_w = cv2.copyMakeBorder(border_b, wt, wt, wt, wt, cv2.BORDER_CONSTANT, value = c_w)
                    anim7 = border_w

代码语言:javascript
复制
if com == 2:
    if im1 == 1:
        im1 = anim1
        im2 = anim2
    elif im1 == 2:
        im1 = anim2
        im2 = anim1
elif com == 3:
    if (im1 == 1) | (im1 == 2) | (im1 == 3):
        if im1 == 1:
            im1 = anim1
        elif im1 == 2:
            im1 = anim2
        elif im1 == 3:
            im1 = anim3
    if (im2 == 1) | (im2 == 2) | (im2 == 3):
        if im2 == 1:
            im2 = anim1
        elif im2 == 2:
            im2 = anim2
        elif im2 == 3:
            im2 = anim3
    if (im3 == 1) | (im3 == 2) | (im3 == 3):
        if im3 == 1:
            im3 = anim1
        elif im3 == 2:
            im3 = anim2
        elif im3 == 3:
            im3 = anim3

//skipped till end of 7 because too repetitive.

elif com == 7:
    if (im1 == 1) | (im1 == 2) | (im1 == 3) | (im1 == 4) | (im1 == 5) | (im1 == 6) | (im1 == 7):
        if im1 == 1:
            im1 = anim1
        elif im1 == 2:
            im1 = anim2
        elif im1 == 3:
            im1 = anim3
        elif im1 == 4:
            im1 = anim4
        elif im1 == 5:
            im1 = anim5
        elif im1 == 6:
            im1 = anim6
        elif im1 == 7:
            im1 = anim7
    if (im2 == 1) | (im2 == 2) | (im2 == 3) | (im2 == 4) | (im2 == 5) | (im2 == 6) | (im2 == 7):
        if im2 == 1:
            im2 = anim1
        elif im2 == 2:
            im2 = anim2
        elif im2 == 3:
            im2 = anim3
        elif im2 == 4:
            im2 = anim4
        elif im2 == 5:
            im2 = anim5
        elif im2 == 6:
            im2 = anim6
        elif im2 == 7:
            im2 = anim7
    if (im3 == 1) | (im3 == 2) | (im3 == 3) | (im3 == 4) | (im3 == 5) | (im3 == 6) | (im3 == 7):
        if im3 == 1:
            im3 = anim1
        elif im3 == 2:
            im3 = anim2
        elif im3 == 3:
            im3 = anim3
        elif im3 == 4:
            im3 = anim4
        elif im3 == 5:
            im3 = anim5
        elif im3 == 6:
            im3 = anim6
        elif im3 == 7:
            im3 = anim7
    if (im4 == 1) | (im4 == 2) | (im4 == 3) | (im4 == 4) | (im4 == 5) | (im4 == 6) | (im4 == 7):
        if im4 == 1:
            im4 = anim1
        elif im4 == 2:
            im4 = anim2
        elif im4 == 3:
            im4 = anim3
        elif im4 == 4:
            im4 = anim4
        elif im4 == 5:
            im4 = anim5
        elif im4 == 6:
            im4 = anim6
        elif im4 == 7:
            im4 = anim7
    if (im5 == 1) | (im5 == 2) | (im5 == 3) | (im5 == 4) | (im5 == 5) | (im5 == 6) | (im5 == 7):
        if im5 == 1:
            im5 = anim1
        elif im5 == 2:
            im5 = anim2
        elif im5 == 3:
            im5 = anim3
        elif im5 == 4:
            im5 = anim4
        elif im5 == 5:
            im5 = anim5
        elif im5 == 6:
            im5 = anim6
        elif im5 == 7:
            im5 = anim7
    if (im6 == 1) | (im6 == 2) | (im6 == 3) | (im6 == 4) | (im6 == 5) | (im6 == 6) | (im6 == 7):
        if im6 == 1:
            im6 = anim1
        elif im6 == 2:
            im6 = anim2
        elif im6 == 3:
            im6 = anim3
        elif im6 == 4:
            im6 = anim4
        elif im6 == 5:
            im6 = anim5
        elif im6 == 6:
            im6 = anim6
        elif im6 == 7:
            im6 = anim7
    if (im7 == 1) | (im7 == 2) | (im7 == 3) | (im7 == 4) | (im7 == 5) | (im7 == 6) | (im7 == 7):
        if im7 == 1:
            im7 = anim1
        elif im7 == 2:
            im7 = anim2
        elif im7 == 3:
            im7 = anim3
        elif im7 == 4:
            im7 = anim4
        elif im7 == 5:
            im7 = anim5
        elif im7 == 6:
            im7 = anim6
        elif im7 == 7:
            im7 = anim7

tl;dr:我如何使这些不必要的重复代码更加简化?

EN

回答 2

Stack Overflow用户

回答已采纳

发布于 2021-04-26 10:24:20

第一段代码可以使用一个函数来消除讨厌的布尔逻辑、数组和循环,以消除硬编码变量。

代码语言:javascript
复制
# Replaces im1 - im7
im_values = []
for i in range(7):
    im_values.append(None)

# Map functions to array
im_functions = []
im_functions.append(im_1)
im_functions.append(im_2)
im_functions.append(im_3)
im_functions.append(im_4)
im_functions.append(im_5)
im_functions.append(im_6)
im_functions.append(im_7)

# Checks the long if-tests in your code, a helper function
def any_equal(n):
    for i in range(n-1):
        for j in range(i+1, n):
            if (im_values[i] == im_values[j]):
                return True
    return False

# All hardcoded if tests are replaced with a for loop
#    cv2.imshow("")
layout = int(input("Enter layout number: "))
for i in range(com):
    im_values[i] = im_functions[i]()
    while(any_equal(com)):
        print("Invalid")
        for j in range(com):
            im_values[j] = im_functions[j]()

代码的第二部分看起来可以用一个简单的函数代替。

代码语言:javascript
复制
anims = []
for i in range(7):
    anims.append(None)

def load_anim(img):
    anim = cv2.imread(img)
    border_b = cv2.copyMakeBorder(anim, bt, bt, bt, bt, cv2.BORDER_CONSTANT, value = c_b)
    border_w = cv2.copyMakeBorder(border_b, wt, wt, wt, wt, cv2.BORDER_CONSTANT, value = c_w)
    return border_w

if i != 0:
    anims[i-1] = load_anim(f"anim_{i}.jpg")

第三部分看起来类似,只需使用数组和循环,您就应该完成它。我让你自己解决这个问题,希望不会太难:)

票数 0
EN

Stack Overflow用户

发布于 2021-04-26 09:33:37

代码块1:

看看你是否只有在你需要的时候才能定义它们

代码块2:

代码语言:javascript
复制
"anim_"+i+".jpg"

代码块3:

代码语言:javascript
复制
if im1 == 1) | (im1 == 2) ... | (im1 == 7):

应该只是

代码语言:javascript
复制
if im1 <= 7:

对于长的elif链,请使用列表

代码语言:javascript
复制
Anim = [anim0, anim1, anim2]
im1 = Anim[0]

我认为在创建大型项目之前,您可以节省更多的时间学习基础知识。

代码语言:javascript
复制
# example code 

TmpLayout1 = [[1,0],[0,1]]
TmpLayout2 = [[0,1],[0,1]]
ImageLayouts = [TmpLayout1, TmpLayout2]
票数 0
EN
页面原文内容由Stack Overflow提供。腾讯云小微IT领域专用引擎提供翻译支持
原文链接:

https://stackoverflow.com/questions/67263971

复制
相关文章

相似问题

领券
问题归档专栏文章快讯文章归档关键词归档开发者手册归档开发者手册 Section 归档